Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat request: ApisixConsumer CRD add ldap-auth support #1574

Closed
panditha opened this issue Dec 30, 2022 · 3 comments · Fixed by #1588
Closed

feat request: ApisixConsumer CRD add ldap-auth support #1574

panditha opened this issue Dec 30, 2022 · 3 comments · Fixed by #1588
Assignees
Labels
good second issue Some small features, slightly more complicated than good first issue help wanted Extra attention is needed question Further information is requested triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@panditha
Copy link

Issue description

Hi,

We are planning to use APISIX in kubernetees and managing all yaml (instead of dashboard) to promote configuration as a code practice. We have planned to use ldap authentication for majority of consumers but we realized that current CRD of ApisixConsumer doesn't support ldap-auth and also we don't see any work around other than switching back to dashboard or APIs.

Can you please let us know when it will be available or any workarounds.

Environment

  • your apisix-ingress-controller version (output of apisix-ingress-controller version --long): we use helm charts from API7. (helm repo add apisix https://charts.apiseven.com)
  • your Kubernetes cluster version (output of kubectl version): 1.22
  • if you run apisix-ingress-controller in Bare-metal environment, also show your OS version (uname -a): Not Applicable.

Minimal test code / Steps to reproduce

Not Applicable

Actual result

Not Applicable

Error log

Not Applicable

Expected result

ApisixConsumer CRD should support all authentication plugins.

@tao12345666333 tao12345666333 added the question Further information is requested label Dec 30, 2022
@tao12345666333 tao12345666333 changed the title bug: ApisixConsumer CRD doesn't support ldap-auth feat request: ApisixConsumer CRD add ldap-auth support Dec 30, 2022
@tao12345666333 tao12345666333 added the good second issue Some small features, slightly more complicated than good first issue label Dec 30, 2022
@tao12345666333
Copy link
Member

Thanks for your report.

We really didn't add that functionality yet.

This is a very simple feature, are you interested in adding it?

Here are some examples for reference:

@tao12345666333 tao12345666333 added help wanted Extra attention is needed triage/accepted Indicates an issue or PR is ready to be actively worked on. labels Dec 30, 2022
@machinly
Copy link
Contributor

machinly commented Jan 5, 2023

hi, I implemented this in the private version before, and I sorted it out in the PR #1588.

@tao12345666333 tao12345666333 linked a pull request Jan 6, 2023 that will close this issue
8 tasks
@tao12345666333
Copy link
Member

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good second issue Some small features, slightly more complicated than good first issue help wanted Extra attention is needed question Further information is requested triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants