doc: add apisix_pluginconfig document #1025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
thanks
You should modify this file also https://github.com/apache/apisix-ingress-controller/blob/master/docs/en/latest/config.json
ok |
tao12345666333
added
the
documentation
Baoyuantop
approved these changes
May 19, 2022
juzhiyuan
reviewed
May 19, 2022
| | plugins | array | A series of custom plugins that will be executed once this route rule is matched | | ||
| | plugins[].name | string | The plugin name, see [docs](http://apisix.apache.org/docs/apisix/getting-started) for learning the available plugins. | | ||
| | plugins[].enable | boolean | Whether the plugin is in use | | ||
| | plugins[].config | object | The plugin configuration, fields should be same as in APISIX. | |
There was a problem hiding this comment.
Suggested change
| | plugins[].config | object | The plugin configuration, fields should be same as in APISIX. | | |
| | plugins[].config | object | The plugin configuration, and fields should be the same as in APISIX. | |
| |---------------|----------|----------------------------------------------------| | ||
| | plugins | array | A series of custom plugins that will be executed once this route rule is matched | | ||
| | plugins[].name | string | The plugin name, see [docs](http://apisix.apache.org/docs/apisix/getting-started) for learning the available plugins. | | ||
| | plugins[].enable | boolean | Whether the plugin is in use | |
There was a problem hiding this comment.
Suggested change
| | plugins[].enable | boolean | Whether the plugin is in use | | |
| | plugins[].enable | boolean | Whether the plugin should be enabled | |
There was a problem hiding this comment.
I will merge first, for those small suggestions @neverCase could help to create a new PR :)
There was a problem hiding this comment.
ok, i will open another one
8 tasks
lingsamuel
pushed a commit
to lingsamuel/apisix-ingress-controller
that referenced
this pull request
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change:
What this PR does / why we need it:
issue: #638
Pre-submission checklist: