Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: paraphrasing some descriptions about plugins #1028

Merged
merged 1 commit into from
May 21, 2022
Merged

doc: paraphrasing some descriptions about plugins #1028

merged 1 commit into from
May 21, 2022

Conversation

neverCase
Copy link
Contributor

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

issue: #1025

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

tao12345666333
tao12345666333 approved these changes May 20, 2022
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333 tao12345666333 added the documentation Improvements or additions to documentation label May 20, 2022
@tao12345666333
Copy link
Member

@juzhiyuan PTAL, thanks

@tao12345666333 tao12345666333 merged commit bef2010 into apache:master May 21, 2022
lingsamuel pushed a commit to lingsamuel/apisix-ingress-controller that referenced this pull request May 26, 2022
@neverCase @lingsamuel
doc: paraphrasing some descriptions (apache#1028)
23baf77
@neverCase neverCase deleted the doc branch September 29, 2022 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@guitu168 guitu168 guitu168 approved these changes

@bzp2010 bzp2010 Awaiting requested review from bzp2010

@guoqqqi guoqqqi Awaiting requested review from guoqqqi

@gxthrj gxthrj Awaiting requested review from gxthrj

@leslie-tsang leslie-tsang Awaiting requested review from leslie-tsang

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
Apache APISIX Ingress controller
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@neverCase @tao12345666333 @juzhiyuan @guitu168