Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: namespace_selector invalid when restarting #1238

Merged
merged 8 commits into from
Aug 29, 2022

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Aug 11, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

  • When all namespace do not have labels(namespace_selector), all resources will be monitored, and the namespace_selector function will not be available.
    image

e2e-test:

  • [un-label] When restarting, all ns without labels will be monitored
  • [ingress-controller restart] When restarting, all ns without labels will be monitored

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2022

Codecov Report

Merging #1238 (8d5b28c) into master (fcfa188) will decrease coverage by 0.13%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1238      +/-   ##
==========================================
- Coverage   42.78%   42.65%   -0.14%     
==========================================
  Files          73       73              
  Lines        6477     6478       +1     
==========================================
- Hits         2771     2763       -8     
- Misses       3409     3418       +9     
  Partials      297      297              
Impacted Files Coverage Δ
pkg/api/validation/utils.go 32.43% <ø> (-12.02%) ⬇️
pkg/providers/apisix/translation/apisix_route.go 19.14% <0.00%> (-0.22%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlinsRan AlinsRan marked this pull request as ready for review August 19, 2022 10:12
test/e2e/scaffold/ingress.go Outdated Show resolved Hide resolved
@AlinsRan AlinsRan requested review from tao12345666333 and removed request for gxthrj August 29, 2022 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants