Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v1.5 cherry-pick]fix: namespace_selector invalid when restarting - v1.5.0 #1291

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Aug 29, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@AlinsRan AlinsRan changed the title fix: namespace_selector invalid when restarting (#1238) fix: namespace_selector invalid when restarting (#1291) Aug 29, 2022
@AlinsRan AlinsRan changed the title fix: namespace_selector invalid when restarting (#1291) fix: namespace_selector invalid when restarting Aug 29, 2022
@tao12345666333
Copy link
Member

I want to close and re-open it, to try to trige the CI.

@AlinsRan AlinsRan closed this Aug 30, 2022
@AlinsRan AlinsRan reopened this Aug 30, 2022
@AlinsRan AlinsRan closed this Aug 30, 2022
@AlinsRan AlinsRan reopened this Aug 30, 2022
@AlinsRan
Copy link
Contributor Author

@tao12345666333 Please help me re-run ci.

@tao12345666333
Copy link
Member

okay

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (v1.5.0@ca063cd). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             v1.5.0    #1291   +/-   ##
=========================================
  Coverage          ?   29.50%           
=========================================
  Files             ?       81           
  Lines             ?    10158           
  Branches          ?        0           
=========================================
  Hits              ?     2997           
  Misses            ?     6834           
  Partials          ?      327           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlinsRan AlinsRan changed the title fix: namespace_selector invalid when restarting fix: namespace_selector invalid when restarting - v1.5.0 Sep 1, 2022
@tao12345666333 tao12345666333 merged commit 8241b15 into apache:v1.5.0 Sep 2, 2022
@tao12345666333 tao12345666333 added this to the 1.5.0 milestone Sep 20, 2022
@tao12345666333 tao12345666333 added bug Something isn't working area/controller labels Sep 20, 2022
@tao12345666333 tao12345666333 changed the title fix: namespace_selector invalid when restarting - v1.5.0 [v1.5 cherry-pick]fix: namespace_selector invalid when restarting - v1.5.0 Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants