Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support external service #1306

Merged
merged 15 commits into from
Oct 20, 2022
Merged

Conversation

lingsamuel
Copy link
Member

@lingsamuel lingsamuel commented Aug 31, 2022

Signed-off-by: Ling Samuel lingsamuelgrace@gmail.com

Type of change:

  • New feature provided

What this PR does / why we need it:

First part of #927
Proposal is here: #927 (comment)

This feature is considered unstable because how to implement some features (schemes and ports) is still under discussion.

Doc PR is incoming.

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@tao12345666333
Copy link
Member

This is a new implementation of #726 and #927 , PTAL.

/cc @elvis-cai @purekeeper @BrandonArp @NMichas

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2022

Codecov Report

Merging #1306 (d90912b) into master (5f2c398) will increase coverage by 0.41%.
The diff coverage is 34.89%.

❗ Current head d90912b differs from pull request most recent head 762e488. Consider uploading reports for the commit 762e488 to get more accurate results

@@            Coverage Diff             @@
##           master    #1306      +/-   ##
==========================================
+ Coverage   40.47%   40.88%   +0.41%     
==========================================
  Files          78       78              
  Lines        7076     7232     +156     
==========================================
+ Hits         2864     2957      +93     
- Misses       3897     3934      +37     
- Partials      315      341      +26     
Impacted Files Coverage Δ
pkg/providers/apisix/translation/apisix_plugin.go 57.54% <ø> (ø)
pkg/providers/apisix/translation/translator.go 0.00% <ø> (ø)
pkg/providers/utils/string.go 0.00% <0.00%> (ø)
...kg/providers/apisix/translation/apisix_upstream.go 48.83% <35.29%> (-51.17%) ⬇️
pkg/providers/apisix/translation/apisix_route.go 25.02% <35.83%> (+5.88%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@lingsamuel
Copy link
Member Author

lingsamuel commented Sep 1, 2022

All tests passed

@tao12345666333 tao12345666333 added the changelog Issues with this label should be added to changelog when public a new release label Sep 6, 2022
@tao12345666333
Copy link
Member

could you please resolve conflicts? thanks

@tao12345666333 tao12345666333 self-assigned this Oct 9, 2022
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@tao12345666333 tao12345666333 merged commit 5c79821 into apache:master Oct 20, 2022
shareinto pushed a commit to shareinto/apisix-ingress-controller that referenced this pull request Oct 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller changelog Issues with this label should be added to changelog when public a new release
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants