-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support external service #1306
Conversation
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #1306 +/- ##
==========================================
+ Coverage 40.47% 40.88% +0.41%
==========================================
Files 78 78
Lines 7076 7232 +156
==========================================
+ Hits 2864 2957 +93
- Misses 3897 3934 +37
- Partials 315 341 +26
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
All tests passed |
could you please resolve conflicts? thanks |
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel lingsamuelgrace@gmail.com
Type of change:
What this PR does / why we need it:
First part of #927
Proposal is here: #927 (comment)
This feature is considered unstable because how to implement some features (schemes and ports) is still under discussion.
Doc PR is incoming.