Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support plugin_metadata of apisix #1369

Merged
merged 6 commits into from
Oct 31, 2022

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Sep 28, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@tao12345666333 tao12345666333 linked an issue Sep 30, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Sep 30, 2022

Codecov Report

Merging #1369 (1c39d4c) into master (c38ae66) will decrease coverage by 0.45%.
The diff coverage is 38.09%.

@@            Coverage Diff             @@
##           master    #1369      +/-   ##
==========================================
- Coverage   40.89%   40.43%   -0.46%     
==========================================
  Files          78       82       +4     
  Lines        7231     7436     +205     
==========================================
+ Hits         2957     3007      +50     
- Misses       3933     4081     +148     
- Partials      341      348       +7     
Impacted Files Coverage Δ
pkg/apisix/apisix.go 61.36% <ø> (ø)
pkg/apisix/resource.go 56.79% <0.00%> (-6.23%) ⬇️
pkg/config/config.go 66.34% <ø> (ø)
...providers/k8s/configmap/translation/translation.go 0.00% <0.00%> (ø)
pkg/apisix/plugin_metadata.go 4.39% <4.39%> (ø)
pkg/apisix/nonexistentclient.go 41.20% <9.09%> (-2.07%) ⬇️
pkg/providers/utils/manifest.go 42.79% <54.16%> (-2.83%) ⬇️
pkg/providers/k8s/configmap/translation/parse.go 55.55% <55.55%> (ø)
...ers/k8s/configmap/translation/configyaml_parser.go 80.00% <80.00%> (ø)
pkg/apisix/cluster.go 38.05% <94.11%> (+3.57%) ⬆️
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlinsRan AlinsRan marked this pull request as ready for review September 30, 2022 06:24
@tao12345666333 tao12345666333 added this to the v1.6.0 milestone Oct 8, 2022
pkg/apisix/apisix.go Outdated Show resolved Hide resolved
pkg/apisix/nonexistentclient.go Outdated Show resolved Hide resolved
pkg/apisix/plugin_metadata.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

Proposal: Add support for APISIXPluginMetadata function
4 participants