Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use httptest.NewRequest instead of http.Request as incoming server request in test case #1498

Merged
merged 2 commits into from
Dec 12, 2022

Conversation

ronething
Copy link
Contributor

@ronething ronething commented Dec 8, 2022

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

use httptest.NewRequest instead of http.Request as incoming server request.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@ronething ronething changed the title chore: use httptest.NewRequest instead of http.Request chore: use httptest.NewRequest instead of http.Request as incoming server request in test case Dec 8, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1498 (e77baf4) into master (7511166) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1498   +/-   ##
=======================================
  Coverage   41.26%   41.26%           
=======================================
  Files          83       83           
  Lines        7365     7365           
=======================================
  Hits         3039     3039           
  Misses       3972     3972           
  Partials      354      354           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tao12345666333 tao12345666333 added this to the v1.6.0 milestone Dec 12, 2022
@tao12345666333 tao12345666333 merged commit 2ce1ed3 into apache:master Dec 12, 2022
@ronething ronething deleted the chore/httptest branch December 13, 2022 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants