chore: use httptest.NewRequest instead of http.Request as incoming se…

…rver request
apache · Dec 8, 2022 · e77baf4 · e77baf4
1 parent de9f84f
commit e77baf4
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/pkg/api/router/router_test.go b/pkg/api/router/router_test.go
@@ -60,8 +60,7 @@ func TestApisixHealthz(t *testing.T) {
 func TestMetrics(t *testing.T) {
 	w := httptest.NewRecorder()
 	c, r := gin.CreateTestContext(w)
-	req, err := http.NewRequest("GET", "/metrics", nil)
-	assert.Nil(t, err, nil)
+	req := httptest.NewRequest("GET", "/metrics", nil)
 	c.Request = req
 	mountMetrics(r)
 	metrics(c)
@@ -72,8 +71,7 @@ func TestMetrics(t *testing.T) {
 func TestWebhooks(t *testing.T) {
 	w := httptest.NewRecorder()
 	c, r := gin.CreateTestContext(w)
-	req, err := http.NewRequest("POST", "/validation", nil)
-	assert.Nil(t, err, nil)
+	req := httptest.NewRequest("POST", "/validation", nil)
 	c.Request = req
 	MountWebhooks(r, &apisix.ClusterOptions{})