Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add one more e2e case #156

Merged
merged 3 commits into from
Jan 9, 2021
Merged

test: add one more e2e case #156

merged 3 commits into from
Jan 9, 2021

Conversation

tokers
Copy link
Contributor

@tokers tokers commented Jan 6, 2021

No description provided.

@codecov-io
Copy link

codecov-io commented Jan 6, 2021

Codecov Report

Merging #156 (48aef52) into master (33ceff0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #156   +/-   ##
=======================================
  Coverage   50.21%   50.21%           
=======================================
  Files          30       30           
  Lines        1414     1414           
=======================================
  Hits          710      710           
  Misses        620      620           
  Partials       84       84           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33ceff0...48aef52. Read the comment docs.

@tokers tokers marked this pull request as draft January 6, 2021 10:30
@tokers tokers marked this pull request as ready for review January 8, 2021 13:52
test/e2e/scaffold/crd.go Show resolved Hide resolved
@gxthrj gxthrj merged commit 18be04f into apache:master Jan 9, 2021
gxthrj added a commit that referenced this pull request Jan 9, 2021
* fix: add service & upstream DELETE logic

* fix: modify upstream comment

* fix: apisix can not remove svc sometimes

* add e2e test

* chore: modify code style

* test: add one more e2e case (#156)

* test: add one more e2e case

* chore: removed the useless method

* fix: readd the error handling

* fix: add service & upstream DELETE logic

* fix: modify upstream comment

* fix: apisix can not remove svc sometimes

* add e2e test

* chore: modify code style

Co-authored-by: Alex Zhang <zchao1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants