fix: Solve the problem of final consistency when deleting #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokers
reviewed
Jan 9, 2021
pkg/apisix/resource.go
Outdated
| @@ -116,6 +116,7 @@ func (i *item) upstream(clusterName string) (*v1.Upstream, error) { | |||
| } | |||
|
|
|||
| var ups upstreamItem | |||
| log.Info(string(i.Value)) | |||
There was a problem hiding this comment.
It already logs i.Value in line 112.
| apisixUpstreamYaml, err = c.apisixUpstreamList.ApisixUpstreams(namespace).Get(name) | ||
| if err != nil { | ||
| if errors.IsNotFound(err) { | ||
| log.Infof("apisixUpstraem %s is removed", sqo.Key) |
There was a problem hiding this comment.
Type: apisixUpstraem => apisixUpstream
| log.Infof("apisixUpstraem %s is removed", sqo.Key) | ||
| return nil | ||
| } | ||
| runtime.HandleError(fmt.Errorf("failed to list apisixService %s/%s", sqo.Key, err.Error())) |
There was a problem hiding this comment.
Type: here we are listing ApisixUpstream.
| return | ||
| } | ||
| c.addFunc(newObj) | ||
| var key string |
There was a problem hiding this comment.
Style:
var (
key string
err error
)
test/e2e/scaffold/ingress.go
Outdated
| @@ -77,7 +77,7 @@ spec: | |||
| tcpSocket: | |||
| port: 8080 | |||
| timeoutSeconds: 2 | |||
| image: "apache/apisix-ingress-controller:dev" | |||
| image: "apisix-ingress-controller:dev" | |||
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
==========================================
- Coverage 50.21% 48.39% -1.82%
==========================================
Files 30 30
Lines 1414 1467 +53
==========================================
Hits 710 710
- Misses 620 673 +53
Partials 84 84
Continue to review full report at Codecov.
|
* test: add one more e2e case * chore: removed the useless method * fix: readd the error handling
tokers
approved these changes
Jan 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solve the problem of final consistency when deleting.
Support retry when remove upstream or service failed.
Fix #118