Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CRDs ingressClassName field cannot be modified #1728

Merged
merged 41 commits into from
Apr 11, 2023

Conversation

AlinsRan
Copy link
Contributor

@AlinsRan AlinsRan commented Mar 17, 2023

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches
  • Documentation
  • Refactor
  • Chore
  • CI/CD or Tests

What this PR does / why we need it:

Ref: #1719

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@AlinsRan AlinsRan changed the title Feat/webhook2 feat: CRDs ingressClassName field cannot be modified Mar 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2023

Codecov Report

Merging #1728 (0a48f58) into master (38710e7) will decrease coverage by 0.38%.
The diff coverage is 11.17%.

❗ Current head 0a48f58 differs from pull request most recent head d900ee9. Consider uploading reports for the commit d900ee9 to get more accurate results

@@            Coverage Diff             @@
##           master    #1728      +/-   ##
==========================================
- Coverage   39.72%   39.35%   -0.38%     
==========================================
  Files          92       91       -1     
  Lines        8065     8063       -2     
==========================================
- Hits         3204     3173      -31     
- Misses       4457     4484      +27     
- Partials      404      406       +2     
Impacted Files Coverage Δ
pkg/api/server.go 50.00% <0.00%> (-32.72%) ⬇️
pkg/api/validation/apisix_plugin_config.go 0.00% <0.00%> (ø)
pkg/api/validation/apisix_route.go 0.00% <0.00%> (-24.60%) ⬇️
pkg/api/validation/validator.go 0.00% <0.00%> (ø)
...kg/providers/apisix/translation/apisix_upstream.go 60.75% <0.00%> (-1.58%) ⬇️
pkg/api/validation/utils.go 45.28% <80.00%> (+12.85%) ⬆️
cmd/ingress/ingress.go 83.33% <100.00%> (+0.14%) ⬆️
pkg/api/router/webhook.go 100.00% <100.00%> (ø)
pkg/config/config.go 64.64% <100.00%> (+0.36%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlinsRan AlinsRan marked this pull request as ready for review April 10, 2023 08:13
@tao12345666333 tao12345666333 added this to the v1.7.0 milestone Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

4 participants