-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: dump the namespace content when e2e test cases failed #571
test: dump the namespace content when e2e test cases failed #571
Conversation
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
==========================================
- Coverage 35.04% 35.03% -0.02%
==========================================
Files 55 54 -1
Lines 4557 4556 -1
==========================================
- Hits 1597 1596 -1
Misses 2742 2742
Partials 218 218
Continue to review full report at Codecov.
|
.github/workflows/e2e-test-ci.yml
Outdated
@@ -73,7 +73,7 @@ jobs: | |||
submodules: recursive | |||
- name: Install kind | |||
run: | | |||
curl -Lo ./kind https://kind.sigs.k8s.io/dl/v0.10.0/kind-linux-amd64 | |||
curl -Lo ./kind https://kind.sigs.k8s.io/dl/v0.11.0/kind-linux-amd64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we update to v0.11.1 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
.github/workflows/e2e-test-ci.yml
Outdated
- name: Create K8s cluster | ||
run: | | ||
make kind-up | ||
kubectl get nodes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we need add kubectl wait --for=condition=Ready nodes --all
to wait node ready ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point! Changed.
* chore: fix the count field type in apisix client * fix: show k8s nodes * change: kind version
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
Bugfix
Description
How to fix?
New feature or improvement
Backport patches
Why need to backport?
Source branch
Related commits and pull requests
Target branch