-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support environment variable in config file #745
Conversation
Please resolve the conflicts, thanks! |
…into patch-2 � Conflicts: � test/e2e/scaffold/k8s.go
Codecov Report
@@ Coverage Diff @@
## master #745 +/- ##
==========================================
+ Coverage 31.70% 31.79% +0.09%
==========================================
Files 66 66
Lines 6640 6652 +12
==========================================
+ Hits 2105 2115 +10
- Misses 4280 4281 +1
- Partials 255 256 +1
Continue to review full report at Codecov.
|
The code LGTM. Thanks! But I personally prefer to directly support configuration through environment variables or through configuration files WDYT? @gxthrj @tokers @lilien1010 |
@tao12345666333 In the case that the user chooses to use file configuration instead of commands of container, the use of environment variables is to write sensitive information through downward api and secret. So if the program directly uses env, we need to consider the problem of file configuration and env configuration merging, doesn't make this problem easy. |
Softwares like ETCD and Istio support using environment variables directly, and the precedence is highest, so it's my understanding that we do should support environment variables, configuration file and command line options. |
@tao12345666333 @tokers |
Agree, or this PR might be too large to review. |
Let's move forward, this feature also has some usage scenarios. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Sorry, the #713 closed because I wrongly rebase the upstream code, so now I have initiated a new PR. e2e has been added, can be review again
Please answer these questions before submitting a pull request
Why submit this pull request?
Bugfix
New feature provided
Improve performance
Backport patches
Related issues
request help: Apisix ingress controller config.yaml couldn't read os environment variable #710