Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support environment variable in config file #713

Closed
wants to merge 11 commits into from
Closed

feat: support environment variable in config file #713

wants to merge 11 commits into from

Conversation

nic-6443
Copy link
Member

Please answer these questions before submitting a pull request

@codecov-commenter
Copy link

Codecov Report

Merging #713 (ba75e7b) into master (a01888b) will increase coverage by 0.08%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #713      +/-   ##
==========================================
+ Coverage   32.36%   32.45%   +0.08%     
==========================================
  Files          65       64       -1     
  Lines        6488     6499      +11     
==========================================
+ Hits         2100     2109       +9     
- Misses       4137     4138       +1     
- Partials      251      252       +1     
Impacted Files Coverage Δ
pkg/config/config.go 85.91% <85.71%> (-0.53%) ⬇️
test/e2e/e2e.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a290f12...ba75e7b. Read the comment docs.

@tao12345666333
Copy link
Member

can you add an e2e test case to cover this?

@nic-6443
Copy link
Member Author

can you add an e2e test case to cover this?

OK

@nic-6443 nic-6443 marked this pull request as draft October 26, 2021 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants