-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove BaseURL and AdminKey in config #826
Conversation
Codecov Report
@@ Coverage Diff @@
## master #826 +/- ##
==========================================
- Coverage 32.14% 32.09% -0.06%
==========================================
Files 71 71
Lines 7727 7721 -6
==========================================
- Hits 2484 2478 -6
Misses 4968 4968
Partials 275 275
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a broken change and we should add some hints for users.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks! The code LGTM. I added the Will be merged after the bi-weekly meeting next week. |
Sure, I think so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Type of change:
What this PR does / why we need it:
Remove BaseURL and AdminKey.
Pre-submission checklist: