-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename command line options and update doc #848
Conversation
Sorry for delay. Thanks for your contribution. In fact, after #826, this configuration item has been removed. Can you help replace |
replace --apisix-base-url with --default-apisix-cluster-base-url and --apisix-admin-key with --default-apisix-cluster-admin-key
PTAL. @tao12345666333 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Codecov Report
@@ Coverage Diff @@
## master #848 +/- ##
=======================================
Coverage 32.12% 32.12%
=======================================
Files 70 71 +1
Lines 7724 7725 +1
=======================================
+ Hits 2481 2482 +1
Misses 4968 4968
Partials 275 275
Continue to review full report at Codecov.
|
After the CI is complete, we can merge it. |
Hi @cmssczy, thank you for your contribution! Here is the Contributor T-shirt form[1], if you're interested, kindly take a look :) [1] https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#contributor-t-shirt |
fix typo in development.md
Type of change:
What this PR does / why we need it:
fix typo in development.md
Pre-submission checklist: