Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename command line options and update doc #848

Merged
merged 1 commit into from
Feb 7, 2022
Merged

rename command line options and update doc #848

merged 1 commit into from
Feb 7, 2022

Conversation

nayihz
Copy link
Contributor

@nayihz nayihz commented Jan 26, 2022

fix typo in development.md

Type of change:

  • Bugfix

What this PR does / why we need it:

fix typo in development.md

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@tao12345666333
Copy link
Member

Sorry for delay. Thanks for your contribution.

In fact, after #826, this configuration item has been removed.

Can you help replace --apisix-base-url with --default-apisix-cluster-base-url and --apisix-admin-key with --default-apisix-cluster-admin-key?

@tao12345666333 tao12345666333 added the documentation Improvements or additions to documentation label Feb 7, 2022
replace --apisix-base-url with --default-apisix-cluster-base-url
and --apisix-admin-key with --default-apisix-cluster-admin-key
@nayihz
Copy link
Contributor Author

nayihz commented Feb 7, 2022

Can you help replace --apisix-base-url with --default-apisix-cluster-base-url and --apisix-admin-key with --default-apisix-cluster-admin-key?

PTAL. @tao12345666333

@nayihz nayihz changed the title fix typo in development.md rename command line options and update doc Feb 7, 2022
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #848 (154d263) into master (de52243) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #848   +/-   ##
=======================================
  Coverage   32.12%   32.12%           
=======================================
  Files          70       71    +1     
  Lines        7724     7725    +1     
=======================================
+ Hits         2481     2482    +1     
  Misses       4968     4968           
  Partials      275      275           
Impacted Files Coverage Δ
cmd/ingress/ingress.go 78.43% <100.00%> (ø)
test/e2e/e2e.go 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de52243...154d263. Read the comment docs.

@tao12345666333
Copy link
Member

After the CI is complete, we can merge it.

@tao12345666333 tao12345666333 added this to the 1.5.0 milestone Feb 7, 2022
@tao12345666333 tao12345666333 merged commit df8316a into apache:master Feb 7, 2022
@tao12345666333 tao12345666333 linked an issue Feb 7, 2022 that may be closed by this pull request
@nayihz nayihz deleted the patch-2 branch February 7, 2022 06:20
@lijing-21
Copy link

Hi @cmssczy, thank you for your contribution!

Here is the Contributor T-shirt form[1], if you're interested, kindly take a look :)

[1] https://github.com/apache/apisix/blob/master/CONTRIBUTING.md#contributor-t-shirt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clean up: remove BaseURL and AdminKey in config
5 participants