-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: objects get from lister must be treated as read-only #829
Conversation
…troller into fix-wrong-usage
Codecov Report
@@ Coverage Diff @@
## master #829 +/- ##
=======================================
Coverage 32.07% 32.07%
=======================================
Files 70 71 +1
Lines 7736 7739 +3
=======================================
+ Hits 2481 2482 +1
- Misses 4980 4982 +2
Partials 275 275
Continue to review full report at Codecov.
|
Can you merge from master branch? we have fixed the CI |
Got it |
…troller into fix-wrong-usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Type of change:
What this PR does / why we need it:
The object returned by the kubernetes listserver interface should be immutable, and this rule is explicitly stated in the listserver interface.
If change the object, it will cause some strange behavior, for example: the
oldObject
you get in thecontrol.onUpdate
callback is incorrect.