Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: drop v2beta1 api version #928

Merged
merged 2 commits into from Mar 23, 2022

Conversation

tao12345666333
Copy link
Member

@tao12345666333 tao12345666333 commented Mar 22, 2022

Signed-off-by: Jintao Zhang zhangjintao9020@gmail.com

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

follow #707

I will introduce v2 stable API version in v1.5, and remove v2beta1, this is the first action.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333 tao12345666333 added the changelog Issues with this label should be added to changelog when public a new release label Mar 22, 2022
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2022

Codecov Report

Merging #928 (10e8887) into master (2178857) will increase coverage by 0.99%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #928      +/-   ##
==========================================
+ Coverage   31.91%   32.91%   +0.99%     
==========================================
  Files          73       73              
  Lines        7900     7660     -240     
==========================================
  Hits         2521     2521              
+ Misses       5103     4863     -240     
  Partials      276      276              
Impacted Files Coverage Δ
pkg/api/validation/apisix_consumer.go 0.00% <ø> (ø)
pkg/api/validation/apisix_route.go 24.59% <ø> (+2.85%) ⬆️
pkg/api/validation/apisix_tls.go 0.00% <ø> (ø)
pkg/api/validation/apisix_upstream.go 0.00% <ø> (ø)
pkg/config/config.go 64.64% <ø> (ø)
pkg/ingress/apisix_route.go 0.00% <ø> (ø)
pkg/ingress/controller.go 0.95% <ø> (+<0.01%) ⬆️
pkg/ingress/status.go 0.00% <ø> (ø)
pkg/kube/translation/apisix_route.go 30.93% <ø> (+8.50%) ⬆️
pkg/kube/translation/translator.go 46.07% <ø> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2178857...10e8887. Read the comment docs.

Copy link
Contributor

@gxthrj gxthrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some v2beta1 need to change in docs.

@tao12345666333
Copy link
Member Author

Yes, I created an issue for tracking #929

@tao12345666333 tao12345666333 merged commit 4da91b7 into apache:master Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog Issues with this label should be added to changelog when public a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants