Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: use a uniform CRD APIVersion #707

Closed
5 tasks done
Tracked by #1309
tao12345666333 opened this issue Oct 12, 2021 · 7 comments · Fixed by #746
Closed
5 tasks done
Tracked by #1309

proposal: use a uniform CRD APIVersion #707

tao12345666333 opened this issue Oct 12, 2021 · 7 comments · Fixed by #746
Assignees
Labels
enhancement New feature or request
Projects
Milestone

Comments

@tao12345666333
Copy link
Member

tao12345666333 commented Oct 12, 2021

Currently in this project, we use different apiversions for management of different resources.
However, the frequency of change of different resources is not the same, which leads to management confusion.

E.g

ApisixRoute -> v2beta2
ApisixUpstream -> v1
ApisixTls -> v1
ApisixConsumer -> v2alpha1
ApisixClusterConfig -> v2alpha1

Users who are not familiar with this project may be confused about this, and because of the possible lag in the documentation, users may use the old version.

This aspect will increase the user's learning cost. On the other hand, it will increase the maintenance cost of the project.
We have to maintain mutual references of multiple resources in the code.

So I propose to use a unified CRD apiversion.

In order to achieve this, we can implement it step by step:`

Introduce the v2beta3 apiversion in the APISIX Ingress v1.4, unify all resources to this version, and deprecate all alpha version resources.

Release v2 apiversion in APISIX Ingress v1.5 and mark all beta versions as deprecated.

@tao12345666333
Copy link
Member Author

@tao12345666333 tao12345666333 added this to To do in roadmap Oct 12, 2021
@gxthrj
Copy link
Contributor

gxthrj commented Oct 12, 2021

Agree, The feature can reduce the cost of understanding.

@tao12345666333
Copy link
Member Author

Update:

I think we can drop the v2beta1 support when the v2 API version is introduced in v1.5. This makes the whole easier to maintain.

@github-actions
Copy link

This issue has been marked as stale due to 90 days of inactivity. It will be closed in 30 days if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 31, 2022
tao12345666333 added a commit to tao12345666333/ingress-controller that referenced this issue Nov 3, 2022
ref: apache#707

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@github-actions github-actions bot removed the stale label Nov 15, 2022
@github-actions
Copy link

This issue has been marked as stale due to 90 days of inactivity. It will be closed in 30 days if no further activity occurs. If this issue is still relevant, please simply write any comment. Even if closed, you can still revive the issue at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 21, 2023
@tao12345666333 tao12345666333 added this to the v1.7.0 milestone Jul 25, 2023
@tao12345666333
Copy link
Member Author

After the release of v1.7, we will be able to close this issue.

@tao12345666333
Copy link
Member Author

https://github.com/apache/apisix-ingress-controller/releases/tag/v1.7.0

V1.7.0 has been released. I will close this one. Thanks all !!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
roadmap
In progress
Development

Successfully merging a pull request may close this issue.

2 participants