Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce v2 apiversion #939

Merged
merged 1 commit into from
Mar 28, 2022

Conversation

tao12345666333
Copy link
Member

@tao12345666333 tao12345666333 commented Mar 27, 2022

Signed-off-by: Jintao Zhang zhangjintao9020@gmail.com

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

follow #707

I want to split the task of introducing the v2 API version into multiple PRs for easy review.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Mar 27, 2022

Codecov Report

Merging #939 (ea20e25) into master (75098d1) will increase coverage by 0.99%.
The diff coverage is 12.50%.

@@            Coverage Diff             @@
##           master     #939      +/-   ##
==========================================
+ Coverage   31.90%   32.90%   +0.99%     
==========================================
  Files          72       73       +1     
  Lines        7899     7662     -237     
==========================================
+ Hits         2520     2521       +1     
+ Misses       5103     4865     -238     
  Partials      276      276              
Impacted Files Coverage Δ
pkg/api/validation/apisix_consumer.go 0.00% <ø> (ø)
pkg/api/validation/apisix_route.go 24.59% <ø> (+2.85%) ⬆️
pkg/api/validation/apisix_tls.go 0.00% <ø> (ø)
pkg/api/validation/apisix_upstream.go 0.00% <ø> (ø)
pkg/config/config.go 64.64% <ø> (ø)
pkg/ingress/apisix_route.go 0.00% <0.00%> (ø)
pkg/ingress/compare.go 0.00% <0.00%> (ø)
pkg/ingress/controller.go 0.95% <ø> (+<0.01%) ⬆️
pkg/ingress/namespace.go 0.00% <0.00%> (ø)
pkg/ingress/status.go 0.00% <ø> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb45119...ea20e25. Read the comment docs.

@tao12345666333 tao12345666333 marked this pull request as ready for review March 28, 2022 01:02
@tao12345666333 tao12345666333 added changelog Issues with this label should be added to changelog when public a new release area/controller labels Mar 28, 2022
@tao12345666333 tao12345666333 merged commit 3b99353 into apache:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller changelog Issues with this label should be added to changelog when public a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants