Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change ApisixRoute to v2 api version #943

Merged
merged 4 commits into from
Apr 2, 2022
Merged

feat: change ApisixRoute to v2 api version #943

merged 4 commits into from
Apr 2, 2022

Conversation

tao12345666333
Copy link
Member

Type of change:

  • Bugfix
  • New feature provided
  • Improve performance
  • Backport patches

What this PR does / why we need it:

follow #707

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@tao12345666333
feat: introduce v2 apiversion
ea20e25 
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333
feat: change all ApisixRoute to v2
2b757c7 
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333 tao12345666333 changed the title feat: change ApisixRoute to v2 api version [WIP] feat: change ApisixRoute to v2 api version Mar 29, 2022
@tao12345666333 tao12345666333 marked this pull request as draft March 29, 2022 15:47
@tao12345666333
chore: finish ApisixRoute to v2
300f407 
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333 tao12345666333 changed the title [WIP] feat: change ApisixRoute to v2 api version feat: change ApisixRoute to v2 api version Mar 30, 2022
@tao12345666333 tao12345666333 marked this pull request as ready for review March 30, 2022 17:30
lingsamuel
lingsamuel approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@lingsamuel lingsamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No serious problems, just need to fix compile errors.

@tao12345666333
chore: fix UT
d185c4d 
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
@tao12345666333 tao12345666333 merged commit f58f3d5 into apache:master Apr 2, 2022
@tao12345666333 tao12345666333 mentioned this pull request Apr 8, 2022
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gxthrj gxthrj gxthrj approved these changes

@lingsamuel lingsamuel lingsamuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tao12345666333 @gxthrj @lingsamuel