-
Notifications
You must be signed in to change notification settings - Fork 336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support ApisixPluginConfig v2 #984
Conversation
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #984 +/- ##
==========================================
- Coverage 30.97% 30.74% -0.23%
==========================================
Files 75 75
Lines 8792 8862 +70
==========================================
+ Hits 2723 2725 +2
- Misses 5775 5843 +68
Partials 294 294
Continue to review full report at Codecov.
|
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
8fc3f9f
to
66fb3b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lingsamuel please resolve conflicts. thanks |
@tao12345666333 I solved the conflicts in #989 yesterday, let's finish that PR first. |
hi please resolve the conflics. thanks |
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks
Signed-off-by: Ling Samuel lingsamuelgrace@gmail.com
Type of change: