Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ApisixPluginConfig v2 #984

Merged
merged 6 commits into from
Jun 1, 2022

Conversation

lingsamuel
Copy link
Member

Signed-off-by: Ling Samuel lingsamuelgrace@gmail.com

Type of change:

  • New feature provided

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@lingsamuel lingsamuel marked this pull request as draft April 24, 2022 10:32
@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2022

Codecov Report

Merging #984 (8a551d8) into master (5477fb0) will decrease coverage by 0.22%.
The diff coverage is 2.59%.

@@            Coverage Diff             @@
##           master     #984      +/-   ##
==========================================
- Coverage   30.97%   30.74%   -0.23%     
==========================================
  Files          75       75              
  Lines        8792     8862      +70     
==========================================
+ Hits         2723     2725       +2     
- Misses       5775     5843      +68     
  Partials      294      294              
Impacted Files Coverage Δ
pkg/ingress/apisix_pluginconfig.go 0.00% <0.00%> (ø)
pkg/ingress/controller.go 0.85% <0.00%> (-0.03%) ⬇️
pkg/kube/translation/apisix_pluginconfig.go 36.66% <0.00%> (-36.67%) ⬇️
pkg/kube/translation/translator.go 46.07% <ø> (ø)
cmd/ingress/ingress.go 79.24% <100.00%> (+0.19%) ⬆️
pkg/config/config.go 66.01% <100.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5477fb0...8a551d8. Read the comment docs.

@lingsamuel lingsamuel marked this pull request as ready for review April 27, 2022 05:20
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333 tao12345666333 added this to the 1.5.0 milestone May 11, 2022
@tao12345666333 tao12345666333 added this to In progress in v1.5 Planning via automation May 11, 2022
@tao12345666333 tao12345666333 added changelog Issues with this label should be added to changelog when public a new release area/controller labels May 11, 2022
@tao12345666333 tao12345666333 self-assigned this May 11, 2022
@tao12345666333
Copy link
Member

@lingsamuel please resolve conflicts. thanks

@lingsamuel
Copy link
Member Author

lingsamuel commented May 17, 2022

@tao12345666333 I solved the conflicts in #989 yesterday, let's finish that PR first.

@tao12345666333
Copy link
Member

hi please resolve the conflics. thanks

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks

v1.5 Planning automation moved this from In progress to Reviewer approved Jun 1, 2022
@gxthrj gxthrj merged commit 408eb0d into apache:master Jun 1, 2022
v1.5 Planning automation moved this from Reviewer approved to Done Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller changelog Issues with this label should be added to changelog when public a new release
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants