Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ApisixConsumer v2 #989

Merged
merged 7 commits into from
May 23, 2022
Merged

Conversation

lingsamuel
Copy link
Member

Signed-off-by: Ling Samuel lingsamuelgrace@gmail.com

Type of change:

  • New feature provided

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Apr 28, 2022

Codecov Report

Merging #989 (d93ab79) into master (bb5104e) will decrease coverage by 0.18%.
The diff coverage is 34.00%.

❗ Current head d93ab79 differs from pull request most recent head e1d3352. Consider uploading reports for the commit e1d3352 to get more accurate results

@@            Coverage Diff             @@
##           master     #989      +/-   ##
==========================================
- Coverage   31.00%   30.82%   -0.19%     
==========================================
  Files          74       74              
  Lines        8404     8606     +202     
==========================================
+ Hits         2606     2653      +47     
- Misses       5520     5670     +150     
- Partials      278      283       +5     
Impacted Files Coverage Δ
pkg/ingress/apisix_consumer.go 0.00% <0.00%> (ø)
pkg/ingress/compare.go 0.00% <0.00%> (ø)
pkg/ingress/controller.go 0.87% <0.00%> (-0.02%) ⬇️
pkg/ingress/status.go 0.00% <0.00%> (ø)
pkg/kube/translation/translator.go 46.07% <ø> (ø)
pkg/kube/translation/plugin.go 70.29% <65.93%> (-29.71%) ⬇️
pkg/kube/translation/apisix_consumer.go 69.23% <74.19%> (ø)
cmd/ingress/ingress.go 79.04% <100.00%> (+0.20%) ⬆️
pkg/config/config.go 65.68% <100.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb5104e...e1d3352. Read the comment docs.

@tao12345666333 tao12345666333 self-assigned this May 13, 2022
@tao12345666333 tao12345666333 added this to the 1.5.0 milestone May 13, 2022
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I remember adding jwt-auth to ApisixConsumer recently, I don't see anything about this change

Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
@tao12345666333
Copy link
Member

Thanks! Let's wait for CI

Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tao12345666333 tao12345666333 merged commit f6f0a3b into apache:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants