-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support ApisixConsumer v2 #989
Conversation
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #989 +/- ##
==========================================
- Coverage 31.00% 30.82% -0.19%
==========================================
Files 74 74
Lines 8404 8606 +202
==========================================
+ Hits 2606 2653 +47
- Misses 5520 5670 +150
- Partials 278 283 +5
Continue to review full report at Codecov.
|
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I remember adding jwt-auth to ApisixConsumer recently, I don't see anything about this change
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Signed-off-by: Ling Samuel <lingsamuelgrace@gmail.com>
Thanks! Let's wait for CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ling Samuel lingsamuelgrace@gmail.com
Type of change: