Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: turn off the Lua code coverage check in CI. #2435

Merged
merged 2 commits into from
Oct 16, 2020
Merged

CI: turn off the Lua code coverage check in CI. #2435

merged 2 commits into from
Oct 16, 2020

Conversation

membphis
Copy link
Member

@membphis membphis commented Oct 16, 2020 •
edited
Loading

What this PR does / why we need it:

We don't enable Lua code override now, its output is unstable and this is unacceptable.

Disabling the Lua code override first will make CI run faster.

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible?

juzhiyuan
juzhiyuan approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@juzhiyuan juzhiyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me from codes style

.travis/linux_openresty_runner.sh Show resolved Hide resolved
@membphis membphis merged commit 78910d8 into apache:master Oct 16, 2020
@spacewander spacewander mentioned this pull request Oct 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juzhiyuan juzhiyuan juzhiyuan approved these changes

@spacewander spacewander spacewander approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@membphis @juzhiyuan @spacewander