refactor: moved etcd initialiation to apisix/cli/etcd.lua #2685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tokers
force-pushed
the
improve/cmd-refactor
branch
from
3e1225d
to
a01f84c
Compare
membphis
approved these changes
Nov 17, 2020
|
haha, @tokers you need to rebase your branch |
Firstsawyou
reviewed
Nov 18, 2020
tokers
force-pushed
the
improve/cmd-refactor
branch
from
a01f84c
to
6a54ce5
Compare
|
@membphis Rebased. |
spacewander
requested changes
Nov 18, 2020
membphis
reviewed
Nov 18, 2020
tokers
force-pushed
the
improve/cmd-refactor
branch
from
984f9ab
to
cd9db90
Compare
spacewander
approved these changes
Nov 20, 2020
|
@membphis Need your review again since more changes are introduced. :) |
membphis
approved these changes
Nov 23, 2020
|
@tokers |
tokers
force-pushed
the
improve/cmd-refactor
branch
from
4b2847d
to
256cc37
Compare
|
@spacewander Resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Zhang zchao1995@gmail.com
What this PR does / why we need it:
Move the etcd initialization into
apisix/cli/etcd.lua, some auxiliary functions were moved toapisix/cli/etcd.luaand the yaml configuration file parsing function was moved toapisix/cli/file.lua.Pre-submission checklist: