Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve #3708 #3710

Closed
wants to merge 2 commits into from
Closed

resolve #3708 #3710

wants to merge 2 commits into from

Conversation

iamayushdas
Copy link
Contributor

@iamayushdas iamayushdas commented Mar 1, 2021

What this PR does / why we need it:

Pre-submission checklist:

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added corresponding test cases?
  • Have you modified the corresponding document?
  • Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first

@iamayushdas
Copy link
Contributor Author

updated User Wall picture in README #3708

@juzhiyuan juzhiyuan changed the title #3708 resolve #3708 Mar 1, 2021
README.md Outdated
@@ -319,7 +319,7 @@ Benchmark comparison test [details data](https://gist.github.com/membphis/137db9

A wide variety of companies and organizations use APISIX for research, production and commercial product, including:

<img src="https://raw.githubusercontent.com/api7/website-of-API7/master/user-wall.jpg" width="900" height="500" />
<img src="https://user-images.githubusercontent.com/40708551/109468444-95aeb200-7a92-11eb-9765-c25522d84e41.png" width="725" height="1000" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I noticed that there has a red title 🤔 we will not use it.

Also, we have 40+ users and there have 25 users in this picture, we need all users.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for that i need to add 1 more logo page, will that be ok?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iamayushdas iamayushdas closed this Mar 1, 2021
@juzhiyuan
Copy link
Member

@iamayushdas Hi, I noticed that you closed this PR, anything I could help you?

@iamayushdas
Copy link
Contributor Author

This forked repo was giving some errors. So i forked it again and have pushed my commits and they are now merged by you.

@juzhiyuan
Copy link
Member

aha yes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants