Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

c/driver/postgresql: add basic benchmarks #568

Closed
Tracked by #81
lidavidm opened this issue Mar 30, 2023 · 2 comments · Fixed by #569
Closed
Tracked by #81

c/driver/postgresql: add basic benchmarks #568

lidavidm opened this issue Mar 30, 2023 · 2 comments · Fixed by #569
Assignees
@lidavidm
Milestone
ADBC Libraries 0.4.0

Comments

@lidavidm
Copy link
Member

lidavidm commented Mar 30, 2023 •
edited
Loading

Compare against? pgeon, psycopg, pandas.read_sql, DuckDB adapter

Will help guide the rest of the design
@lidavidm lidavidm added this to the ADBC Libraries 0.4.0 milestone Mar 30, 2023
@lidavidm lidavidm self-assigned this Mar 30, 2023
@lidavidm lidavidm mentioned this issue Mar 30, 2023
Closed
10 tasks
lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 30, 2023
@lidavidm
test(python/adbc_driver_postgres): add benchmark suite via asv
5c1b128 
Fixes apache#568.
@lidavidm lidavidm mentioned this issue Mar 30, 2023
Merged
6 tasks
@kou
Copy link
Member

kou commented Mar 30, 2023

I want them too!
I want to use them for https://github.com/apache/arrow-flight-sql-postgresql too.

@lidavidm
Copy link
Member Author

I put up a draft PR using asv to benchmark the Python driver against psycopg2 and duckdb (still need to add other clients, and expand the benchmarks). I still need to clean them up and make sure they're measuring the right thing (I expected DuckDB to win hands down; I may be setting something up wrong).

lidavidm added a commit to lidavidm/arrow-adbc that referenced this issue Mar 31, 2023
@lidavidm
test(python/adbc_driver_postgres): add benchmark suite via asv
9e79ce3 
Fixes apache#568.
lidavidm added a commit that referenced this issue Apr 19, 2023
@lidavidm
test(python/adbc_driver_postgres): add benchmark suite via asv (#569)
d311397 
No setup for actually running them in CI for now (we also probably don't
want that).

- [x] Benchmark integers at different table sizes
- [x] Benchmark different integer types
- [x] Benchmark different float types
- [x] Benchmark different string types
- [x] Benchmark multiple columns of same type
- [x] Benchmark against Pandas 1.x/SQLALchemy 1.x

Fixes #568.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidavidm lidavidm

Labels
None yet
Projects
None yet
Milestone
ADBC Libraries 0.4.0
Development

Successfully merging a pull request may close this issue.

test(python/adbc_driver_postgres): add benchmark suite via asv lidavidm/arrow-adbc
2 participants
@kou @lidavidm