-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(go/adbc/driver): Adbc Driver for Snowflake #586
Conversation
|
requires snowflakedb/gosnowflake#769 in order to work properly |
Cool! Let me know if you need help adding secrets (but the process should just be file INFRA Jira, then email to private@apache.org when you get the go-ahead, in case you haven't done it before) |
@lidavidm I've filed https://issues.apache.org/jira/browse/INFRA-24477 to get it added. |
@lidavidm This is ready for review now, though the CI/tests aren't going to pass until I get the SNOWFLAKE_URI secret added as per the JIRA ticket I filed. In the meantime, the rest of the code can be reviewed and looked at. Though this still relies on some PRs for the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are some...interesting type conversions we have going on here.
LGTM in general. It seems the driver is mostly straightforward once you get the herculean effort of fixing up the underlying driver out of the way?
57592f8
to
ce07db3
Compare
When calling :cpp:`AdbcConnectionGetTableSchema`, the returned Arrow Schema | ||
will contain metadata on each field: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should eventually standardize something like Flight SQL's scheme for encoding this sort of info...
3004a05
to
fd135f1
Compare
d66c055
to
5321110
Compare
2542b38
to
e84c88c
Compare
@lidavidm My change on the snowflake repo has been merged and I've updated the go.mod here to point to that commit hash. They release on a monthly schedule so the next actual release which will include this change won't be until the end of May, at which point we can update the go.mod to point to that specific version tag. So this is good to go! |
Actually, I should update the install and package files for this shouldn't I? or should that be a separate change? |
Up to you - whatever is easier |
204468e
to
d52f697
Compare
Initial work to start creating a snowflake ADBC driver which we can eventually package up like we do for the Flight SQL driver. Currently only
GetInfo
andGetObjects
are implemented, but it's a start!Will have to add secrets to the repo eventually to allow tests to work.
This relies on snowflakedb/gosnowflake#781 getting merged first