Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add QueryArrowStream to snowflakeConn #781

Merged
merged 13 commits into from
Apr 27, 2023

Conversation

zeroshade
Copy link
Contributor

@zeroshade zeroshade commented Apr 20, 2023

Description

Added a method to snowflakeConn called QueryArrowStream which returns a loader object which can be used to retrieve io.ReadClosers which are Arrow IPC streams of record batches of results. This allows a consumer to fetch Arrow data directly without having to rely on using the "exact same" version of the arrow library as this driver does.

This was instrumental in building out the Snowflake ADBC Driver as per apache/arrow-adbc#586

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zeroshade
Copy link
Contributor Author

@sfc-gh-igarish would you please re-run the tests, I was unable to replicate the test failure myself but I did see one situation where there's a difference in some logic so I think the last change should fix the issue. If not I'll likely need some help debugging this from you guys since I can't replicate this at all on my end hitting my own snowflake test warehouse.

@sfc-gh-igarish sfc-gh-igarish merged commit 79f2d00 into snowflakedb:master Apr 27, 2023
@zeroshade zeroshade deleted the arrow-friendly branch April 27, 2023 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants