-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add QueryArrowStream to snowflakeConn #781
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sfc-gh-igarish would you please re-run the tests, I was unable to replicate the test failure myself but I did see one situation where there's a difference in some logic so I think the last change should fix the issue. If not I'll likely need some help debugging this from you guys since I can't replicate this at all on my end hitting my own snowflake test warehouse. |
Description
Added a method to
snowflakeConn
calledQueryArrowStream
which returns a loader object which can be used to retrieveio.ReadCloser
s which are Arrow IPC streams of record batches of results. This allows a consumer to fetch Arrow data directly without having to rely on using the "exact same" version of the arrow library as this driver does.This was instrumental in building out the Snowflake ADBC Driver as per apache/arrow-adbc#586
Checklist
make fmt
to fix inconsistent formatsmake lint
to get lint errors and fix all of them