Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new logo svg with white background #313

Merged
merged 1 commit into from
May 12, 2021

Conversation

parthsarthy
Copy link
Contributor

Which issue does this PR close?

Closes #67

Rationale for this change

Logo is not visible when github appearance changed to Dark mode.

  • Adds new logo svg with white background and corresponding PNG. Also updated the readme.

What changes are included in this PR?

Logo is not visible when github appearance changed to Dark mode.

  • Adds new logo svg with white background and corresponding PNG. Also updated the readme.

Are there any user-facing changes?

No

@parthsarthy parthsarthy changed the title add new logo svg with white background Add new logo svg with white background May 10, 2021
@Dandandan
Copy link
Contributor

image

@parthsarthy I think it makes sense to add some white margin?

@Dandandan
Copy link
Contributor

Let's merge this - a white margin could be added later!

@Dandandan Dandandan merged commit 3e7fed8 into apache:master May 12, 2021
@parthsarthy
Copy link
Contributor Author

Let's merge this - a white margin could be added later!

@Dandandan I've opened another PR to add some spacing around the logo - #411

@houqp houqp added datafusion Changes in the datafusion crate documentation Improvements or additions to documentation labels Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DataFusion logo needs a white background
5 participants