Skip to content

Commit

Permalink
remove stray TODOs
Browse files Browse the repository at this point in the history
  • Loading branch information
nevi-me committed May 11, 2021
1 parent 2894b3f commit a9fb246
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion parquet/src/arrow/arrow_writer.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1366,7 +1366,7 @@ mod tests {
let a_list_data = ArrayData::builder(DataType::List(Box::new(Field::new(
"item",
DataType::Int32,
true, // TODO: why does this fail when false? Is it related to logical nulls?
false,
))))
.len(5)
.add_buffer(a_value_offsets)
Expand Down
1 change: 0 additions & 1 deletion parquet/src/arrow/levels.rs
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,6 @@ impl LevelInfo {
unreachable!("Cannot have a root as a child")
}
(LevelType::List(_), _) => {
// Always add 1 (TDDO: document why)
self.max_definition + 1 + level_type.level_increment()
}
(LevelType::Struct(_), _) => {
Expand Down

0 comments on commit a9fb246

Please sign in to comment.