Skip to content

Commit

Permalink
address feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
andygrove committed Jun 16, 2022
1 parent d64f888 commit c91f355
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions arrow/src/record_batch.rs
Expand Up @@ -140,10 +140,9 @@ impl RecordBatch {

for (c, f) in columns.iter().zip(&schema.fields) {
if !f.is_nullable() && c.null_count() > 0 {
if f.name().len() == 0 {
// hacky workaround for known issue with dictionary IPC encoding
// https://github.com/apache/arrow-rs/issues/1892
} else {
// hacky workaround for known issue with dictionary IPC encoding
// https://github.com/apache/arrow-rs/issues/1892
if !f.name().is_empty() {
return Err(ArrowError::InvalidArgumentError(format!(
"Column '{}' is declared as non-nullable but contains null values",
f.name()
Expand Down

0 comments on commit c91f355

Please sign in to comment.