Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused ArrowArrayReader in parquet #1197

Closed
alamb opened this issue Jan 18, 2022 · 0 comments · Fixed by #1234
Closed

Remove unused ArrowArrayReader in parquet #1197

alamb opened this issue Jan 18, 2022 · 0 comments · Fixed by #1234
Labels
parquet Changes to the parquet crate

Comments

@alamb
Copy link
Contributor

alamb commented Jan 18, 2022

#1082 removed the use of ArrowArrayReader in favor of a different approach;

This ticket tracks removing ArrowArrayReader added in #384? . @yordan-pavlov reported that he ran the benchmarks against the latest code and @tustvold 's work is now often several times faster in almost all cases and in the one or two cases where it isn't the difference is small - congratulations @tustvold ; plus I think @tustvold 's array reader could be made faster still

Originally posted by @yordan-pavlov in #1082 (comment)
@alamb alamb mentioned this issue Jan 18, 2022
Merged
This was referenced Jan 19, 2022
Merged
Closed
Closed
tustvold added a commit to tustvold/arrow-rs that referenced this issue Jan 23, 2022
@tustvold
Remove arrow array reader (apache#1197)
0f0ba7a
@tustvold tustvold mentioned this issue Jan 23, 2022
Merged
alamb pushed a commit that referenced this issue Jan 24, 2022
@tustvold
Remove arrow array reader (#1197) (#1234)
6ed1992
@alamb alamb added the parquet Changes to the parquet crate label Feb 3, 2022
@alamb alamb changed the title Remove ArrowArrayReader in parquet implementation Remove unused ArrowArrayReader in parquet Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
parquet Changes to the parquet crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove arrow array reader (#1197) tustvold/arrow-rs
1 participant
@alamb