Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove arrow array reader (#1197) #1234

Merged
merged 2 commits into from
Jan 24, 2022

Conversation

tustvold
Copy link
Contributor

@tustvold tustvold commented Jan 23, 2022

Which issue does this PR close?

This is preventing fixing #1230 and interfering with progress on #1154 and #1225 and so I think the time has come to remove this.

Closes #1197.

Rationale for this change

See ticket

What changes are included in this PR?

Removes ArrowArrayReader

Are there any user-facing changes?

No, this was made an experimental API in #1134

FYI @yordan-pavlov

@github-actions github-actions bot added the parquet Changes to the parquet crate label Jan 23, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2022

Codecov Report

Merging #1234 (b8e1c84) into master (d801ac2) will increase coverage by 0.11%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1234      +/-   ##
==========================================
+ Coverage   82.82%   82.94%   +0.11%     
==========================================
  Files         179      178       -1     
  Lines       52170    51346     -824     
==========================================
- Hits        43210    42589     -621     
+ Misses       8960     8757     -203     
Impacted Files Coverage Δ
parquet/src/util/test_common/page_util.rs 88.88% <0.00%> (-2.03%) ⬇️
parquet/src/util/memory.rs 89.25% <0.00%> (-1.87%) ⬇️
arrow/src/array/transform/mod.rs 84.78% <0.00%> (-0.79%) ⬇️
arrow/src/datatypes/field.rs 53.79% <0.00%> (-0.31%) ⬇️
parquet/src/encodings/encoding.rs 93.52% <0.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d801ac2...b8e1c84. Read the comment docs.

@yordan-pavlov
Copy link
Contributor

ArrowArrayReader was quite self-contained so, as expected, easy to remove - thanks @tustvold;

@alamb alamb merged commit 6ed1992 into apache:master Jan 24, 2022
@alamb
Copy link
Contributor

alamb commented Jan 24, 2022

Thanks @yordan-pavlov and @tustvold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused ArrowArrayReader in parquet
4 participants