Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs.rs build is broken #1695

Closed
alamb opened this issue May 12, 2022 · 4 comments · Fixed by #1696
Closed

Docs.rs build is broken #1695

alamb opened this issue May 12, 2022 · 4 comments · Fixed by #1696
Assignees
Labels

Comments

@alamb
Copy link
Contributor

alamb commented May 12, 2022

Describe the bug
I broke docs.rs build by merging #1349 without testing it first

To Reproduce
I have tested / reproduced by running the builds from this branch: master...alamb:alamb/test_crates_publish

This is what happening

https://docs.rs/crate/parquet/0.18.0

Check logs: https://docs.rs/crate/parquet/0.18.0/builds/557342

[INFO] [stderr] WARNING: Your kernel does not support swap limit capabilities or the cgroup is not mounted. Memory limited without swap.
[INFO] [stdout] c7db694a1e0ec0a7df60f4774a81f3d15861a69233e9177971982b83d9da03dd
[INFO] running `Command { std: "docker" "start" "-a" "c7db694a1e0ec0a7df60f4774a81f3d15861a69233e9177971982b83d9da03dd", kill_on_drop: false }`
[INFO] [stderr]  Documenting parquet v0.18.0 (/opt/rustwide/workdir)
[INFO] [stderr] error[E0658]: `#[doc(cfg)]` is experimental
[INFO] [stderr]    --> src/arrow/mod.rs:124:21
[INFO] [stderr]     |
[INFO] [stderr] 124 | #[cfg_attr(doc_cfg, doc(cfg(feature = "async")))]
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: see issue #43781 <https://github.com/rust-lang/rust/issues/43781> for more information
[INFO] [stderr]     = help: add `#![feature(doc_cfg)]` to the crate attributes to enable
[INFO] [stderr] 
[INFO] [stderr] error: Compilation failed, aborting rustdoc
[INFO] [stderr] 
[INFO] [stderr] For more information about this error, try `rustc --explain E0658`.
[INFO] [stderr] error: could not document `parquet`
[INFO] [stderr] 
[INFO] [stderr] Caused by:
[INFO] [stderr]   process didn't exit successfully: `rustdoc --edition=2021 --crate-type lib --crate-name parquet src/lib.rs --target x86_64-unknown-linux-gnu -o /opt/rustwide/target/x86_64-unknown-linux-gnu/doc --cfg 'feature="arrow"' --cfg 'feature="async"' --cfg 'feature="base64"' --cfg 'feature="brotli"' --cfg 'feature="clap"' --cfg 'feature="cli"' --cfg 'feature="default"' --cfg 'feature="experimental"' --cfg 'feature="flate2"' --cfg 'feature="futures"' --cfg 'feature="lz4"' --cfg 'feature="serde_json"' --cfg 'feature="snap"' --cfg 'feature="test_common"' --cfg 'feature="tokio"' --cfg 'feature="zstd"' --error-format=json --json=diagnostic-rendered-ansi,artifacts,future-incompat -C metadata=78f9c9e2e62425b8 -L 
...

Expected behavior
docs.rs build should succeed

Additional context

YOLO in this case was not a good idea: #1349 (comment)

@alamb alamb added the bug label May 12, 2022
@alamb
Copy link
Contributor Author

alamb commented May 12, 2022

cc @@HaoYang670

@alamb
Copy link
Contributor Author

alamb commented May 12, 2022

I am now trying https://crates.io/crates/parquet/0.18.1 , with this change: alamb@3f76ef3

@alamb
Copy link
Contributor Author

alamb commented May 12, 2022

I will fix this

@alamb
Copy link
Contributor Author

alamb commented May 12, 2022

https://docs.rs/parquet/0.18.1/parquet/ seems to have worked! I'll make a real PR to arrow

The link is even correct 🎉

Screen Shot 2022-05-12 at 4 11 49 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant