Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs.rs build #1696

Merged
merged 1 commit into from
May 13, 2022
Merged

Fix docs.rs build #1696

merged 1 commit into from
May 13, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented May 12, 2022

Which issue does this PR close?

Closes #1695

Rationale for this change

I broke docs.rs build by merging #1349 without testing it first (shame on me!)

What changes are included in this PR?

Fix the build by removing unneeded part of 1349

I tested this by temporarily publishing an ancient version of parquet to crates.io from this branch https://github.com/alamb/arrow-rs/tree/alamb/test_crates_publish and verifying the docs built correctly

You can see the results here:

Are there any user-facing changes?

Docs will work correctly when published on crates.io

cc @HaoYang670 @viirya @tustvold

@github-actions github-actions bot added the parquet Changes to the parquet crate label May 12, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1696 (e57d8d8) into master (101edc9) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1696      +/-   ##
==========================================
- Coverage   83.10%   83.09%   -0.01%     
==========================================
  Files         193      193              
  Lines       56011    56011              
==========================================
- Hits        46547    46545       -2     
- Misses       9464     9466       +2     
Impacted Files Coverage Δ
parquet_derive/src/parquet_field.rs 65.75% <0.00%> (-0.46%) ⬇️
arrow/src/datatypes/datatype.rs 65.09% <0.00%> (-0.37%) ⬇️
parquet/src/encodings/encoding.rs 93.65% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 101edc9...e57d8d8. Read the comment docs.

@alamb
Copy link
Contributor Author

alamb commented May 12, 2022

I plan to merge this when the test has completed

@HaoYang670
Copy link
Contributor

Just a small nit in PR description:
Replace Closes # #1695 with Closes #1695

@alamb
Copy link
Contributor Author

alamb commented May 13, 2022

Thanks all

@alamb alamb merged commit cb41427 into apache:master May 13, 2022
@alamb alamb deleted the alamb/fix_docs_builds branch May 13, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs.rs build is broken
5 participants