Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading parquet files with a corrupt ARROW:schema panics #2855

Closed
noselasd opened this issue Oct 9, 2022 · 0 comments · Fixed by #3130
Closed

Reading parquet files with a corrupt ARROW:schema panics #2855

noselasd opened this issue Oct 9, 2022 · 0 comments · Fixed by #3130
Labels
bug good first issue Good for newcomers help wanted parquet Changes to the parquet crate

Comments

@noselasd
Copy link

noselasd commented Oct 9, 2022

Describe the bug
I've encountered a likely corrupt parquet file, containing an ARROW:schema of just 2 bytes. This panics inside arrow when
reading that file.

The issue seems to be here, which isn't verifying a minimal length:

let slice = if bytes[0..4] == [255u8; 4] {

Expected behavior

Error returned instead of panic.

@noselasd noselasd added the bug label Oct 9, 2022
@tustvold tustvold added help wanted good first issue Good for newcomers parquet Changes to the parquet crate labels Oct 10, 2022
tustvold pushed a commit that referenced this issue Nov 21, 2022
* Adding len checks

* Adding test case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Good for newcomers help wanted parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants