Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Panic on Reading Corrupt Parquet Schema (#2855) #3130

Merged
merged 2 commits into from
Nov 21, 2022

Conversation

psvri
Copy link
Contributor

@psvri psvri commented Nov 17, 2022

Which issue does this PR close?

Closes #2855.

Rationale for this change

We were accessing the slice without checks and hence panics.

What changes are included in this PR?

Added the check

Are there any user-facing changes?

No

@github-actions github-actions bot added the parquet Changes to the parquet crate label Nov 17, 2022
@tustvold tustvold changed the title Fix bug #2855 Fix Panic on Reading Corrupt Parquet Schema (#2855) Nov 21, 2022
Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we possibly get a simple unit test of this, e.g. calling get_arrow_schema_from_metadata with an empty string

@tustvold tustvold merged commit 6f8187f into apache:master Nov 21, 2022
@ursabot
Copy link

ursabot commented Nov 21, 2022

Benchmark runs are scheduled for baseline = e1b5657 and contender = 6f8187f. 6f8187f is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@psvri psvri deleted the paruet-fix branch November 21, 2022 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading parquet files with a corrupt ARROW:schema panics
3 participants