-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DictionaryArray::try_new()
to create dictionaries from pre existing arrays
#1300
Add DictionaryArray::try_new()
to create dictionaries from pre existing arrays
#1300
Conversation
DictionaryArray::try_new()
to create dictionaries from pre existing arrays
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks. This can make writing dictionary array test much easier!
Looks good. The double validation for the dictionary values is a bit unfortunate, but since this is mostly a convenience feature that should be fine. |
Co-authored-by: Liang-Chi Hsieh <viirya@gmail.com>
329e77b
to
9044d94
Compare
I agree it is unfortunately I'll see if I can make a |
Filed #1313 to track performance improvement |
Thanks for the comments and review @jhorstmann and @viirya |
Draft as it builds on #1263Which issue does this PR close?
Closes #1299
Rationale for this change
Inspired by the challenge writing tests on #1263 from @viirya
Otherwise known as "no one should have to write the following to work with
DictionaryArrays
":Click to expand!
What changes are included in this PR?
DictionaryArray::try_new()
functionDictionaryArray
support ineq_dyn
kernel #1263 to use the new API