Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy clippy::vec_init_then_push lint #1303

Merged
merged 1 commit into from Feb 13, 2022
Merged

Fix clippy clippy::vec_init_then_push lint #1303

merged 1 commit into from Feb 13, 2022

Conversation

gsserge
Copy link
Contributor

@gsserge gsserge commented Feb 12, 2022

Which issue does this PR close?

This is part of #1255

Rationale for this change

It's beneficial to run clippy as strict as possible.

What changes are included in this PR?

This PR enables clippy::vec_init_then_push lint in the arrow crate and fixes all the relates testing code for this check to pass.

Are there any user-facing changes?

No.

@github-actions github-actions bot added the arrow Changes to the arrow crate label Feb 12, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @gsserge !

@codecov-commenter
Copy link

Codecov Report

Merging #1303 (0eccb4a) into master (8f7c56e) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1303      +/-   ##
==========================================
- Coverage   83.01%   83.01%   -0.01%     
==========================================
  Files         180      180              
  Lines       52731    52728       -3     
==========================================
- Hits        43775    43771       -4     
- Misses       8956     8957       +1     
Impacted Files Coverage Δ
arrow/src/array/array_struct.rs 89.28% <100.00%> (ø)
arrow/src/array/array_union.rs 90.71% <100.00%> (-0.05%) ⬇️
arrow/src/array/builder.rs 86.73% <100.00%> (-0.01%) ⬇️
arrow/src/compute/kernels/limit.rs 100.00% <100.00%> (ø)
parquet_derive/src/parquet_field.rs 65.75% <0.00%> (-0.46%) ⬇️
parquet/src/encodings/encoding.rs 93.71% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f7c56e...0eccb4a. Read the comment docs.

@Dandandan Dandandan merged commit 16fd5e0 into apache:master Feb 13, 2022
@Dandandan
Copy link
Contributor

Thanks @gsserge !

@gsserge gsserge deleted the clippy_vec_init_then_push branch February 13, 2022 09:00
@alamb alamb changed the title arrow: enable clippy::vec_init_then_push lint Fix clippy enable clippy::vec_init_then_push lint Feb 16, 2022
@alamb alamb changed the title Fix clippy enable clippy::vec_init_then_push lint Fix clippy clippy::vec_init_then_push lint Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants