Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all clippy lints in arrow crate #1255

Closed
alamb opened this issue Feb 1, 2022 · 2 comments · Fixed by #1324
Closed

Fix all clippy lints in arrow crate #1255

alamb opened this issue Feb 1, 2022 · 2 comments · Fixed by #1324
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers

Comments

@alamb
Copy link
Contributor

alamb commented Feb 1, 2022

Describe the bug
Due to "historical reasons" there are several clippy lints that are disabled in the arrow crate
https://github.com/apache/arrow-rs/blob/master/arrow/src/lib.rs#L130-L141

#![allow(dead_code)]
#![allow(non_camel_case_types)]
#![deny(clippy::redundant_clone)]
#![allow(
    // introduced to ignore lint errors when upgrading from 2020-04-22 to 2020-11-14
    clippy::float_equality_without_abs,
    clippy::type_complexity,
    // upper_case_acronyms lint was introduced in Rust 1.51.
    // It is triggered in the ffi module, and ipc::gen, which we have no control over
    clippy::upper_case_acronyms,
    clippy::vec_init_then_push
)]

It would be great to clean up the code to pass these lints for tidiness

To Reproduce
Remove one of the #[allow] lines above, run clippy

Expected behavior
Clippy runs cleanly without blank #allow across the whole crate

Additional context
Add any other context about the problem here.

@alamb alamb added enhancement Any new improvement worthy of a entry in the changelog arrow Changes to the arrow crate good first issue Good for newcomers labels Feb 1, 2022
@gsserge
Copy link
Contributor

gsserge commented Feb 12, 2022

I'd like to work on this one. One PR per lint rule should make it easier to review and integrate.

@alamb
Copy link
Contributor Author

alamb commented Feb 12, 2022

Thanks @gsserge that would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants