Enable more clippy lints in arrow #1315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1315 +/- ##
=======================================
Coverage 83.01% 83.02%
=======================================
Files 180 180
Lines 52810 52810
=======================================
+ Hits 43840 43843 +3
+ Misses 8970 8967 -3
Continue to review full report at Codecov.
|
|
It's kinda weird that the "Docs are clean" job with |
alamb
approved these changes
Feb 16, 2022
| @@ -247,7 +247,7 @@ jobs: | |||
| run: | | |||
| export CARGO_HOME="/github/home/.cargo" | |||
| export CARGO_TARGET_DIR="/github/home/target" | |||
| cargo clippy --features test_common --features prettyprint --features=async --all-targets --workspace -- -D warnings -A clippy::redundant_field_names | |||
| @@ -27,6 +27,7 @@ pub mod writer; | |||
| #[allow(clippy::extra_unused_lifetimes)] | |||
| #[allow(clippy::redundant_static_lifetimes)] | |||
| #[allow(clippy::redundant_field_names)] | |||
| #[allow(non_camel_case_types)] | |||
jhorstmann
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This is part of #1255
Rationale for this change
It's beneficial to run clippy as strict as possible.
What changes are included in this PR?
This PR enables a few clippy and compiler lints in the
arrowcrate and fixes the related code.Are there any user-facing changes?
No.