Refactor RecordBatch::validate_new_batch

[HaoYang670]

Which issue does this PR close?

Closes #1350.

Rationale for this change

There is some repetitive code in the function validate_new_batch, which are not easy to maintain. We rewrite this function to make it more clear.

Are there any user-facing changes?

No.

[HaoYang670]

Performance

run cargo bench -- json_list_primitive_to_record_batch

Before

json_list_primitive_to_record_batch                                                                             
                        time:   [17.513 us 17.536 us 17.563 us]
                        change: [+0.0716% +0.4880% +0.8879%] (p = 0.01 < 0.05)
                        Change within noise threshold.
Found 11 outliers among 100 measurements (11.00%)
  2 (2.00%) low mild
  4 (4.00%) high mild
  5 (5.00%) high severe

After

json_list_primitive_to_record_batch                                                                             
                        time:   [16.754 us 16.769 us 16.785 us]
                        change: [+0.4428% +1.0700% +1.7171%] (p = 0.00 < 0.05)
                        Change within noise threshold.
Found 10 outliers among 100 measurements (10.00%)
  4 (4.00%) high mild
  6 (6.00%) high severe

No performance penalty.

[codecov-commenter]

Codecov Report

Merging #1361 (c119805) into master (a69f0d1) will decrease coverage by 0.04%.
The diff coverage is 68.42%.

@@            Coverage Diff             @@
##           master    #1361      +/-   ##
==========================================
- Coverage   83.04%   82.99%   -0.05%     
==========================================
  Files         181      181              
  Lines       52925    52929       +4     
==========================================
- Hits        43950    43929      -21     
- Misses       8975     9000      +25     

Impacted Files	Coverage Δ
arrow/src/record_batch.rs	94.00% <68.42%> (+2.02%)	⬆️
parquet/src/file/statistics.rs	91.73% <0.00%> (-2.07%)	⬇️
parquet/src/util/cursor.rs	77.31% <0.00%> (-1.69%)	⬇️
parquet/src/schema/types.rs	85.64% <0.00%> (-1.51%)	⬇️
arrow/src/csv/writer.rs	71.32% <0.00%> (-0.82%)	⬇️
arrow/src/json/writer.rs	91.77% <0.00%> (-0.70%)	⬇️
arrow/src/array/array_dictionary.rs	91.12% <0.00%> (-0.47%)	⬇️
arrow/src/array/data.rs	83.15% <0.00%> (-0.44%)	⬇️
arrow/src/datatypes/datatype.rs	66.40% <0.00%> (-0.40%)	⬇️
arrow/src/ipc/writer.rs	83.14% <0.00%> (-0.32%)	⬇️
... and 11 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a69f0d1...c119805. Read the comment docs.

[HaoYang670]

Rebuild after #1362 is fixed.

[alamb]

Looks like a nice cleanup to me. Thank you @HaoYang670

[HaoYang670]

Is it ready to be merged?

[alamb]

Yes, thank you @HaoYang670 !