-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor RecordBatch::validate_new_batch
#1361
Refactor RecordBatch::validate_new_batch
#1361
Conversation
Signed-off-by: remzi <13716567376yh@gmail.com>
Signed-off-by: remzi <13716567376yh@gmail.com>
simplify the iterator Signed-off-by: remzi <13716567376yh@gmail.com>
Performancerun Beforejson_list_primitive_to_record_batch
time: [17.513 us 17.536 us 17.563 us]
change: [+0.0716% +0.4880% +0.8879%] (p = 0.01 < 0.05)
Change within noise threshold.
Found 11 outliers among 100 measurements (11.00%)
2 (2.00%) low mild
4 (4.00%) high mild
5 (5.00%) high severe Afterjson_list_primitive_to_record_batch
time: [16.754 us 16.769 us 16.785 us]
change: [+0.4428% +1.0700% +1.7171%] (p = 0.00 < 0.05)
Change within noise threshold.
Found 10 outliers among 100 measurements (10.00%)
4 (4.00%) high mild
6 (6.00%) high severe No performance penalty. |
Codecov Report
@@ Coverage Diff @@
## master #1361 +/- ##
==========================================
- Coverage 83.04% 82.99% -0.05%
==========================================
Files 181 181
Lines 52925 52929 +4
==========================================
- Hits 43950 43929 -21
- Misses 8975 9000 +25
Continue to review full report at Codecov.
|
Rebuild after #1362 is fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a nice cleanup to me. Thank you @HaoYang670
Is it ready to be merged? |
Yes, thank you @HaoYang670 ! |
Which issue does this PR close?
Closes #1350.
Rationale for this change
There is some repetitive code in the function
validate_new_batch
, which are not easy to maintain. We rewrite this function to make it more clear.Are there any user-facing changes?
No.