-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move csv Parser trait and its implementations to utils module #1385
Conversation
this allow the parser capabilities to be re-used for json module
Codecov Report
@@ Coverage Diff @@
## master #1385 +/- ##
=======================================
Coverage 83.10% 83.10%
=======================================
Files 181 182 +1
Lines 53244 53236 -8
=======================================
- Hits 44247 44243 -4
+ Misses 8997 8993 -4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sum12
Other than the pub
vs pub(crate)
thing, this looks like a good change to me!
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
I merged master into this PR to get the fix for #1398 Assuming the CI checks pass, I'll plan to merge it in |
Which issue does this PR close?
spill over form #1301
Rationale for this change
This one just moves code around does some touch up as suggested there.
What changes are included in this PR?
Along with moving code it also implements
parse_formatted
for date32 type and removes the redundant match onself::DATA_TYPE
Are there any user-facing changes?