Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move csv Parser trait and its implementations to utils module #1385

Merged
merged 6 commits into from
Mar 6, 2022

Conversation

sum12
Copy link
Contributor

@sum12 sum12 commented Mar 2, 2022

Which issue does this PR close?

spill over form #1301

Rationale for this change

This one just moves code around does some touch up as suggested there.

What changes are included in this PR?

Along with moving code it also implements parse_formatted for date32 type and removes the redundant match on self::DATA_TYPE

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Mar 2, 2022
@sum12 sum12 changed the title Move to utils Move Parser trait and its implementations to utils module Mar 2, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2022

Codecov Report

Merging #1385 (7f6d65c) into master (ab41c25) will increase coverage by 0.00%.
The diff coverage is 65.21%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1385   +/-   ##
=======================================
  Coverage   83.10%   83.10%           
=======================================
  Files         181      182    +1     
  Lines       53244    53236    -8     
=======================================
- Hits        44247    44243    -4     
+ Misses       8997     8993    -4     
Impacted Files Coverage Δ
arrow/src/csv/reader.rs 89.89% <ø> (+1.56%) ⬆️
arrow/src/util/reader_parser.rs 65.21% <65.21%> (ø)
arrow/src/array/transform/mod.rs 86.20% <0.00%> (-0.23%) ⬇️
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (ø)
arrow/src/datatypes/datatype.rs 66.80% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab41c25...7f6d65c. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sum12

Other than the pub vs pub(crate) thing, this looks like a good change to me!

arrow/src/util/mod.rs Outdated Show resolved Hide resolved
arrow/src/util/reader_parser.rs Outdated Show resolved Hide resolved
sum12 and others added 2 commits March 4, 2022 09:01
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
@alamb
Copy link
Contributor

alamb commented Mar 4, 2022

Thanks @sum12 -- the integration test is failing due to #1398 (not changes in this PR) -- I am trying to figure out what is happening

@alamb
Copy link
Contributor

alamb commented Mar 6, 2022

I merged master into this PR to get the fix for #1398

Assuming the CI checks pass, I'll plan to merge it in

@alamb alamb changed the title Move Parser trait and its implementations to utils module Move csv Parser trait and its implementations to utils module Mar 6, 2022
@alamb alamb merged commit a2a9ea8 into apache:master Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants