-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix clippy errors in 1.60 #1527
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1527 +/- ##
=======================================
Coverage 82.75% 82.75%
=======================================
Files 190 190
Lines 54754 54754
=======================================
Hits 45310 45310
Misses 9444 9444
Continue to review full report at Codecov.
|
Do we need a follow-on PR to really fix the lints? |
that would be a good idea @HaoYang670 . Thank you The |
The |
Can drop this after rebase on commit 5f16f92 "fix clippy errors in 1.60 (apache#1527)", first released in 12.0.0
Can drop this after rebase on commit 5f16f92 "fix clippy errors in 1.60 (apache#1527)", first released in 12.0.0
Can drop this after rebase on commit 5f16f92 "fix clippy errors in 1.60 (apache#1527)", first released in 12.0.0
Can drop this after rebase on commit 5f16f92 "fix clippy errors in 1.60 (apache#1527)", first released in 12.0.0
Rationale
Rust 1.60 is released 🎉
Clippy has added some new lints which were failing on CI
Changes
"Fix" lints (by telling clippy to ignore them) to get CI clean