Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix clippy errors in 1.60 #1527

Merged
merged 1 commit into from
Apr 8, 2022
Merged

fix clippy errors in 1.60 #1527

merged 1 commit into from
Apr 8, 2022

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Apr 7, 2022

Rationale

Rust 1.60 is released 🎉

Clippy has added some new lints which were failing on CI

Changes

"Fix" lints (by telling clippy to ignore them) to get CI clean

@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels Apr 7, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1527 (cd36d0d) into master (688dd4c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1527   +/-   ##
=======================================
  Coverage   82.75%   82.75%           
=======================================
  Files         190      190           
  Lines       54754    54754           
=======================================
  Hits        45310    45310           
  Misses       9444     9444           
Impacted Files Coverage Δ
arrow/src/ffi.rs 87.52% <ø> (ø)
parquet/src/arrow/schema.rs 85.68% <ø> (ø)
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (-0.23%) ⬇️
arrow/src/array/transform/mod.rs 86.57% <0.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 688dd4c...cd36d0d. Read the comment docs.

@HaoYang670
Copy link
Contributor

Do we need a follow-on PR to really fix the lints?

@alamb
Copy link
Contributor Author

alamb commented Apr 8, 2022

I don't expect we'll release datafusion-cli to crates.io

that would be a good idea @HaoYang670 . Thank you

The from_int32 issues might be fine to rename if they are not part of the public API

@alamb alamb merged commit 5f16f92 into apache:master Apr 8, 2022
@HaoYang670
Copy link
Contributor

The manual_bits has a minor problem and I have added a comment:
rust-lang/rust-clippy#8213 (comment)

@alamb alamb deleted the alamb/fix_clippy branch April 10, 2022 11:07
MazterQyou pushed a commit to cube-js/arrow-rs that referenced this pull request Jul 13, 2022
MazterQyou pushed a commit to cube-js/arrow-rs that referenced this pull request Aug 4, 2022
mcheshkov added a commit to cube-js/arrow-rs that referenced this pull request Aug 26, 2024
Can drop this after rebase on commit 5f16f92 "fix clippy errors in 1.60 (apache#1527)", first released in 12.0.0
mcheshkov added a commit to cube-js/arrow-rs that referenced this pull request Aug 27, 2024
Can drop this after rebase on commit 5f16f92 "fix clippy errors in 1.60 (apache#1527)", first released in 12.0.0
mcheshkov added a commit to cube-js/arrow-rs that referenced this pull request Sep 5, 2024
Can drop this after rebase on commit 5f16f92 "fix clippy errors in 1.60 (apache#1527)", first released in 12.0.0
mcheshkov added a commit to cube-js/arrow-rs that referenced this pull request Sep 5, 2024
Can drop this after rebase on commit 5f16f92 "fix clippy errors in 1.60 (apache#1527)", first released in 12.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants