Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bench command line options #1685

Merged
merged 1 commit into from
May 12, 2022
Merged

fix bench command line options #1685

merged 1 commit into from
May 12, 2022

Conversation

kazuk
Copy link
Contributor

@kazuk kazuk commented May 11, 2022

I working for #1660

fix to criterion bench not accepts options

error: Unrecognized option: 'save-baseline'
error: bench failed

bheisler/criterion.rs#193 (comment)

Which issue does this PR close?

None

Rationale for this change

not working cargo bench -- --save-baseline tag and cargo bench -- --baseline tag.

What changes are included in this PR?

add bench = false to Cargo.toml [lib]

fix to criterion bench not accepts options

```
error: Unrecognized option: 'save-baseline'
error: bench failed
```
bheisler/criterion.rs#193 (comment)
@github-actions github-actions bot added arrow Changes to the arrow crate parquet Changes to the parquet crate labels May 11, 2022
@viirya
Copy link
Member

viirya commented May 11, 2022

Is cargo bench --bench benchmarks -- --save-baseline foo a workaround too?

@codecov-commenter
Copy link

Codecov Report

Merging #1685 (f185b69) into master (19f0ada) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1685   +/-   ##
=======================================
  Coverage   83.11%   83.12%           
=======================================
  Files         193      193           
  Lines       56177    56177           
=======================================
+ Hits        46694    46696    +2     
+ Misses       9483     9481    -2     
Impacted Files Coverage Δ
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (ø)
arrow/src/array/transform/mod.rs 87.02% <0.00%> (+0.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19f0ada...f185b69. Read the comment docs.

@kazuk
Copy link
Contributor Author

kazuk commented May 11, 2022

Yes, cargo bench --bench some_bench -- --save-baseline tag is working without this PR.

But, too hard to compare all bench result.

Copy link
Member

@viirya viirya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, not sure if I may miss some Cargo usage. I also don't find we use bench attribute in code.

@alamb alamb merged commit b425d17 into apache:master May 12, 2022
@kazuk kazuk deleted the fix_bench_cli_options branch May 12, 2022 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate parquet Changes to the parquet crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants