Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: Refine OffsetSizeTrait to extend num::Integer #1702

Merged
merged 1 commit into from
May 16, 2022

Conversation

HaoYang670
Copy link
Contributor

Signed-off-by: remzi 13716567376yh@gmail.com

Which issue does this PR close?

None.

Rationale for this change

Offsets are always integers, so OffsetSizeTrait should be a superset of Interger.

What changes are included in this PR?

Add Integer, remove Num and Ord.

Are there any user-facing changes?

No.

Signed-off-by: remzi <13716567376yh@gmail.com>
@github-actions github-actions bot added the arrow Changes to the arrow crate label May 15, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1702 (9c96cdc) into master (ff182f1) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1702   +/-   ##
=======================================
  Coverage   83.27%   83.28%           
=======================================
  Files         195      195           
  Lines       55937    55937           
=======================================
+ Hits        46584    46587    +3     
+ Misses       9353     9350    -3     
Impacted Files Coverage Δ
arrow/src/array/array_list.rs 96.16% <ø> (ø)
arrow/src/array/transform/mod.rs 87.02% <0.00%> (+0.11%) ⬆️
parquet_derive/src/parquet_field.rs 66.21% <0.00%> (+0.22%) ⬆️
arrow/src/datatypes/datatype.rs 65.45% <0.00%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff182f1...9c96cdc. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@alamb
Copy link
Contributor

alamb commented May 16, 2022

cc @tustvold

@alamb alamb changed the title Minor: Refine OffsetSizeTrait Minor: Refine OffsetSizeTrait to extend num::Integer May 16, 2022
@alamb alamb merged commit 3135a53 into apache:master May 16, 2022
@HaoYang670 HaoYang670 deleted the refine_offset_trait branch May 17, 2022 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants