Add min_binary and max_binary aggregate kernels
#1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: remzi <13716567376yh@gmail.com>
nevi-me
approved these changes
May 24, 2022
viirya
reviewed
May 24, 2022
| } | ||
|
|
||
| #[test] | ||
| fn test_binary_min_max_1() { |
There was a problem hiding this comment.
We have a similar test for string:
https://github.com/apache/arrow-rs/blob/master/arrow/src/compute/kernels/aggregate.rs#L902-L907
Actually, I don't know why it is named _1, just copy from it.
viirya
approved these changes
May 24, 2022
alamb
changed the title
min_max_binarymin_binary and max_binary aggregate kernels
|
Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: remzi 13716567376yh@gmail.com
Which issue does this PR close?
Closes #1724.
What changes are included in this PR?
Are there any user-facing changes?
2 new public functions
min_binaryandmax_binary