Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve integration test document to follow Arrow C++ repo CI #1742

Merged
merged 2 commits into from
May 25, 2022

Conversation

viirya
Copy link
Member

@viirya viirya commented May 24, 2022

Which issue does this PR close?

Closes #1741.

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@viirya viirya added the documentation Improvements or additions to documentation label May 24, 2022
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2022

Codecov Report

Merging #1742 (1a30d42) into master (5cf06bf) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 1a30d42 differs from pull request most recent head 9aa7a0b. Consider uploading reports for the commit 9aa7a0b to get more accurate results

@@            Coverage Diff             @@
##           master    #1742      +/-   ##
==========================================
- Coverage   83.32%   83.31%   -0.01%     
==========================================
  Files         196      196              
  Lines       55961    55961              
==========================================
- Hits        46627    46624       -3     
- Misses       9334     9337       +3     
Impacted Files Coverage Δ
parquet_derive/src/parquet_field.rs 65.75% <0.00%> (-0.23%) ⬇️
arrow/src/array/transform/mod.rs 86.74% <0.00%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5cf06bf...9aa7a0b. Read the comment docs.

@viirya
Copy link
Member Author

viirya commented May 24, 2022

cc @alamb

Copy link
Contributor

@tustvold tustvold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused why we are documenting what the C++ repo does in the Rust repo? Are you perhaps suggesting we should run with --gold-dirs?

@viirya
Copy link
Member Author

viirya commented May 25, 2022

If we want to enable these tests in the C++ repo, we need to pass --gold-dirs test too. Currently although we can pass all producer/consumer tests between C++/Rust according to our doc, it fails --gold-dirs test in C++ repo CI. This update is to reflect this point.

@alamb
Copy link
Contributor

alamb commented May 25, 2022

I'm a little confused why we are documenting what the C++ repo does in the Rust repo? Are you perhaps suggesting we should run with --gold-dirs?

The C++ repo is used in the rust repo's CI test:

steps:
- name: Checkout Arrow
uses: actions/checkout@v2
with:
repository: apache/arrow
submodules: true
fetch-depth: 0

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @viirya

@alamb alamb merged commit 105be5a into apache:master May 25, 2022
@alamb alamb added the arrow Changes to the arrow crate label May 25, 2022
@viirya
Copy link
Member Author

viirya commented May 25, 2022

Thanks @alamb @tustvold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve integration test document to follow Arrow C++ repo CI
4 participants